[PATCH] D106717: [SimplifyCFG] Don't speculatively execute BB[s] if they are predictably not taken

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 25 14:09:35 PDT 2021


lebedev.ri added a comment.

In D106717#2903320 <https://reviews.llvm.org/D106717#2903320>, @spatel wrote:

> LGTM - as with the similar D106650 <https://reviews.llvm.org/D106650>, I think we could use 1-2 more tests with a metadata/branch prob just below getPredictableBranchThreshold(), so we verify that calculation works as expected.

Will do, thank you for the review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106717/new/

https://reviews.llvm.org/D106717



More information about the llvm-commits mailing list