[PATCH] D106707: [OpenMP] Introduce RAII to protect certain RTL calls from DCE
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 25 10:58:52 PDT 2021
jdoerfert added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1818-1821
+ ExternalizationRAII(OMPInfoCache,
+ OMPRTL___tgt_target_data_begin_mapper_wait);
+ ExternalizationRAII(OMPInfoCache,
+ OMPRTL___tgt_target_data_begin_mapper_issue);
----------------
jdoerfert wrote:
> `_tgt_...` are not device runtime functions, no need to have them here.
You need to create objects with a lifetime that matches the scope. You are creating unnamed objects here that die right away.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106707/new/
https://reviews.llvm.org/D106707
More information about the llvm-commits
mailing list