[PATCH] D106720: [WIP][Attributor] AAFunctionReachability, Instruction reachability.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:4360
+  virtual bool instCanReach(Attributor &A, Instruction &Inst,
+                            Function *Fn) const = 0;
+
----------------
Spell `inst` out in the function name, pass function as reference, (or is a nullptr ok?)


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8734
+    return Change;
+  }
+
----------------
I don't get the backwards stuff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106720/new/

https://reviews.llvm.org/D106720