[PATCH] D104641: Strip undef implying attributes when moving calls

Sun Jul 25 09:37:00 PDT 2021

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Rebase on 087a8eea359a <https://reviews.llvm.org/rG087a8eea359a4d8ef22c42fddca3b09833928c6a> should make it a bit smaller. I'm unsure why the nonnull is listed in `PopulateUndefImplyingAttributes` I guess after the rebase it will be gone and the tests that drop it won't anymore.

seems there are no more real concerns, so LGTM if the rebase works out as expected.

================
Comment at: llvm/test/Transforms/LICM/call-hoisting.ll:31
+; However, we need not strip the nonnull attribute since it just propagates
+; poison if the parameter was indeed nonnull.
 define void @test_strip_attribute(i32* noalias %loc, i32* noalias %sink, i32* %q) {
----------------

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104641/new/

https://reviews.llvm.org/D104641