[PATCH] D106687: [OpenMP] Only register HeapToShared in the OpenMPOpt module pass

Sat Jul 24 20:48:04 PDT 2021

jhuber6 added a comment.

In D106687#2902826 <https://reviews.llvm.org/D106687#2902826>, @jdoerfert wrote:

> We should instead keep `noinline` on them till the CGSCC pass, at least for this one as it could trigger late even if it wasn't possible early.

But we run the Module pass and CGSCC passes at different optimization levels right now. It's possible that H2S could remove something after more optimizations, but I haven't seen any examples of something failing to be moved to the stack because of optimizations.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106687/new/

https://reviews.llvm.org/D106687