[PATCH] D97106: [UpdateTestChecks] Warn if any function conflicts under the same prefix

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_test_checks/prefix_conflicts.test:1
+# Verify the script warns about conflicts of prefix in multiple run lines
+# RUN: cp -f %S/Inputs/conflict.ll %t.ll
----------------
Add a period.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_test_checks/prefix_conflicts.test:2
+# Verify the script warns about conflicts of prefix in multiple run lines
+# RUN: cp -f %S/Inputs/conflict.ll %t.ll
+# RUN: %update_test_checks %t.ll 2>&1 | FileCheck %s
----------------
no need for -f. `cp` is sufficient.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:276
+    for prefix, funcs in self._get_failed_prefixes():
+      warn('Prefix %s had conflicting output from different RUN lines for functions: %s' % (
+          prefix, ', '.join(funcs)))
----------------
https://llvm.org/docs/CodingStandards.html#error-and-warning-messages

It is more common not to capitalize the message.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:348
+        if funcs:
+            yield (prefix, funcs)
 
----------------
2 column indentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97106/new/

https://reviews.llvm.org/D97106