[PATCH] D106749: [IR] Consider non-willreturn as side effect
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 24 12:10:21 PDT 2021
jdoerfert added a comment.
I like us to check `willreturn` and consider it an effect. I think we should rename the function though, two reasons:
1. it changes the behavior and people will be confused.
2. lang ref talks about "side-effects" and we would need to make it consistent (e.g., for `mustprogress`)
That said, 2) should be addressed anyway separately anyway. I would not oppose to look for side-effect everywhere and define it
to include termination properly. Does this make sense?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106749/new/
https://reviews.llvm.org/D106749
More information about the llvm-commits
mailing list