[PATCH] D105207: [debuginfo][lsr] SCEV-based salvaging for LoopStrengthReduction

Chris Jackson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 24 10:04:13 PDT 2021


chrisjackson updated this revision to Diff 361465.
chrisjackson added a comment.

After a rebase I observed additional DVIs that were single location op when cached (pre-LSR) but had multiple location ops post-LSR, when scev-salvaging was applied. Instead of skipping these, restore the pre-LSR information and attempt SCEV salvaging.

Thanks for the review @jmorse, I will address your comments next.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105207/new/

https://reviews.llvm.org/D105207

Files:
  llvm/include/llvm/Transforms/Utils/ScalarEvolutionExpander.h
  llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
  llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp
  llvm/test/Transforms/LoopStrengthReduce/dbg-preserve-0.ll
  llvm/test/Transforms/LoopStrengthReduce/dbg-preserve-2.ll
  llvm/test/Transforms/LoopStrengthReduce/debuginfo-scev-variadic-value-0.ll
  llvm/test/Transforms/LoopStrengthReduce/debuginfo-scev-variadic-value-1.ll
  llvm/test/Transforms/LoopStrengthReduce/debuginfo-scev-variadic-value-2.ll
  llvm/test/Transforms/LoopStrengthReduce/debuginfo-scev-variadic-value-3.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105207.361465.patch
Type: text/x-patch
Size: 48198 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210724/473985b8/attachment.bin>


More information about the llvm-commits mailing list