[PATCH] D106588: [CSSPGO] Tweak ICP threshold in top-down inliner

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

Thanks for working on the tuning. The switch names could be confusing. How about name them this way:

- `sample-profile-icp-relative-hotness`: default to 25.
- `sample-profile-icp-relative-hotness-skip`: default to 1, with description "Skip relative hotness check for ICP up to given number of targets." (we have `icp-csskip` for PGO ICP, which is named similarly)



================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:202
+    "sample-profile-icp-count-threshold", cl::Hidden, cl::init(1),
+    cl::desc("Always allow the number of promotions in proirity-based sample "
+             "profile loader inlining."));
----------------
always allow isn't accurate - we only skip the relative hotness check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106588/new/

https://reviews.llvm.org/D106588