[PATCH] D105315: [flang] Move External IO tests to use GTest

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 16:48:07 PDT 2021


Meinersbur added a comment.

Sorry for the wait. Flang-OldUnit indeed currently does not run under `ninja make-check` because Windows executables have an `.exe` suffix (`external-io.test.exe`) that is not in lit's `suffixes` list. The CMake target otherwise unusual name is `external-io.text` (or `external-io-slow`) because

  config.suffixes = [".test"]

in NonGTestUnit/lit.cfg.py. Glad that this is fixing this.

The Windows fails are fixed by D106726 <https://reviews.llvm.org/D106726>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105315/new/

https://reviews.llvm.org/D105315



More information about the llvm-commits mailing list