[PATCH] D104764: [CMake] Don't LTO optimize targets on Darwin either

Azharuddin Mohammed via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 16:11:32 PDT 2021


azharudd added a comment.

In D104764#2895658 <https://reviews.llvm.org/D104764#2895658>, @phosek wrote:

> In D104764#2895650 <https://reviews.llvm.org/D104764#2895650>, @azharudd wrote:
>
>> @phosek, the config where I'm seeing this is a two stage bootstrap build. Could you try building again with the just built clang and see if it still works for you? I seem to be able to reliably reproduce the error locally.
>
> Yes, that's what we use on our bots as well. However, I just noticed that your bots are using ThinLTO, is that correct? We always use full LTO and it's possible that this issue only manifests in ThinLTO.

Yes, correct, this is with ThinLTO. I tried full LTO and I don't see the error, so, yes this appears to be an issue only with ThinLTO.

For now, let me guard this behavior to if its not ThinLTO, until we get the root cause fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104764/new/

https://reviews.llvm.org/D104764



More information about the llvm-commits mailing list