[PATCH] D106684: [x86] improve CMOV codegen by pushing add into operands, part 2

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 16:02:08 PDT 2021


spatel added a comment.

In D106684#2900784 <https://reviews.llvm.org/D106684#2900784>, @lebedev.ri wrote:

> Hmm, could you please add tests with 64-bit `add` immediate?

Good catch - this transform is based on being able to use immediate operands to save instructions. If the constants are too big, then we should not do it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106684/new/

https://reviews.llvm.org/D106684



More information about the llvm-commits mailing list