[PATCH] D106629: [lld/mac] Implement for section$start and section$ end symbols

[Nico Weber via Phabricator via llvm-commits]

thakis marked an inline comment as done.
thakis added a comment.

i get feedbac



================
Comment at: lld/test/MachO/start-end.s:141
+
+## Secton-rename tests.
+## Input section __FOO/__bar is renamed to output section
----------------
int3 wrote:
> 
Whoops, missed this. Fixed in a follow-up.


================
Comment at: lld/test/MachO/start-end.s:260
+.fill 1
+
+.subsections_via_symbols
----------------
oontvoo wrote:
> thakis wrote:
> > int3 wrote:
> > > would it be worthwhile to add a zerofill section to the test, to make sure the `$end` symbol occurs after the zeroes?
> > Sure, done. Seems to Just Work, but yes, that's a good thing to test.
> "Just Work", famous last words 🤔
I'm sure I managed to hide a bug or two somewhere :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106629/new/

https://reviews.llvm.org/D106629