[PATCH] D106711: [lld/mac] Fix start-stop.s test with expensive checks enabled

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 14:01:23 PDT 2021


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG04f5eb407c74: [lld/mac] Fix start-stop.s test with expensive checks enabled (authored by thakis).
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106711/new/

https://reviews.llvm.org/D106711

Files:
  lld/MachO/OutputSegment.cpp


Index: lld/MachO/OutputSegment.cpp
===================================================================
--- lld/MachO/OutputSegment.cpp
+++ lld/MachO/OutputSegment.cpp
@@ -146,10 +146,8 @@
 }
 
 void macho::sortOutputSegments() {
-  // sort() instead of stable_sort() is fine because segmentOrder() is
-  // name-based and getOrCreateOutputSegment() makes there's only a single
-  // segment for every name.
-  llvm::sort(outputSegments, compareByOrder<OutputSegment *>(segmentOrder));
+  llvm::stable_sort(outputSegments,
+                    compareByOrder<OutputSegment *>(segmentOrder));
 }
 
 static DenseMap<StringRef, OutputSegment *> nameToOutputSegment;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106711.361343.patch
Type: text/x-patch
Size: 662 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210723/eab24980/attachment.bin>


More information about the llvm-commits mailing list