[PATCH] D106703: [libunwind] adds a way to synthesise libgcc

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

If I'm understanding correctly, there are two components to this: shared libraries, and static libraries.

If you have both libgcc_s.so and libunwind.so in the same process, exposing APIs with the same names, the result is confusing at best, sure.  Either we need APIs with different names, or libunwind.so needs to replace libgcc_s.so.  Ideally, we'd do both, to give users flexibility.  But if we're not going to rename the libunwind.so APIs, we shouldn't install libunwind.so at all, since it isn't usable.

For the static libraries, I'm not sure what problem you're trying to solve.  If someone tries to link against both sets of static libraries, that's pretty clearly user error.  And the symbols have hidden visibility, so they shouldn't interfere with other shared libraries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106703/new/

https://reviews.llvm.org/D106703