[PATCH] D106629: [lld/mac] Implement for section$start and section$ end symbols

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 13:02:45 PDT 2021


oontvoo added inline comments.


================
Comment at: lld/test/MachO/start-end.s:260
+.fill 1
+
+.subsections_via_symbols
----------------
thakis wrote:
> int3 wrote:
> > would it be worthwhile to add a zerofill section to the test, to make sure the `$end` symbol occurs after the zeroes?
> Sure, done. Seems to Just Work, but yes, that's a good thing to test.
"Just Work", famous last words 🤔


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106629/new/

https://reviews.llvm.org/D106629



More information about the llvm-commits mailing list