[PATCH] D106684: [x86] improve CMOV codegen by pushing add into operands, part 2

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 10:23:00 PDT 2021


lebedev.ri added a comment.

Hmm, could you please add tests with 64-bit `add` immediate?



================
Comment at: llvm/test/CodeGen/X86/add-cmov.ll:125-126
-; CHECK-NEXT:    movl $43, %eax
-; CHECK-NEXT:    cmovgel %ecx, %eax
-; CHECK-NEXT:    addl %edi, %eax
 ; CHECK-NEXT:    retq
----------------
The other benefit is that the `add` can execute without waiting for the `cmov`.
https://godbolt.org/z/zz5EKhrKj


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106684/new/

https://reviews.llvm.org/D106684



More information about the llvm-commits mailing list