[PATCH] D106598: [llvm-rc] Allow dashes as part of resource name strings
Adrian McCarthy via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 23 10:03:03 PDT 2021
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
I see. I didn't realize llvm-rc used an actual separate preprocessor step. (RC has a crude one built-in that doesn't quite match any of the standards.)
Given external preprocessing, I can't think of any other problems that allowing `-` in identifiers would introduce, so this LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106598/new/
https://reviews.llvm.org/D106598
More information about the llvm-commits
mailing list