[PATCH] D106286: [RISCV] Add a test showing an incorrect vsetvli insertion

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 09:27:47 PDT 2021


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1ffc3693949c: [RISCV] Add a test showing an incorrect vsetvli insertion (authored by frasercrmck, committed by craig.topper).

Changed prior to commit:
  https://reviews.llvm.org/D106286?vs=360377&id=361258#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106286/new/

https://reviews.llvm.org/D106286

Files:
  llvm/test/CodeGen/RISCV/rvv/vsetvli-regression.ll


Index: llvm/test/CodeGen/RISCV/rvv/vsetvli-regression.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/RISCV/rvv/vsetvli-regression.ll
@@ -0,0 +1,22 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=riscv64 -mattr=+experimental-v | FileCheck %s
+
+; This test checks a regression in the vsetvli insertion pass. We used to
+; prserve the VL on the second vsetvli with ratio e32/m1, when the the last
+; update of VL was the vsetvli with e64/m4. Changing VTYPE here changes VLMAX
+; which may make the original VL invalid. Instead of preserving it we use 0.
+
+define i32 @illegal_preserve_vl(<vscale x 2 x i32> %a, <vscale x 4 x i64> %x, <vscale x 4 x i64>* %y) {
+; CHECK-LABEL: illegal_preserve_vl:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    vsetvli a1, zero, e64, m4, ta, mu
+; CHECK-NEXT:    vadd.vv v28, v12, v12
+; CHECK-NEXT:    vs4r.v v28, (a0)
+; CHECK-NEXT:    vsetivli zero, 0, e32, m1, ta, mu
+; CHECK-NEXT:    vmv.x.s a0, v8
+; CHECK-NEXT:    ret
+  %index = add <vscale x 4 x i64> %x, %x
+  store <vscale x 4 x i64> %index, <vscale x 4 x i64>* %y
+  %elt = extractelement <vscale x 2 x i32> %a, i64 0
+  ret i32 %elt
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106286.361258.patch
Type: text/x-patch
Size: 1249 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210723/363fd76c/attachment.bin>


More information about the llvm-commits mailing list