[PATCH] D106635: [AArch64][AsmParser] NFC: Parser.getTok().getLoc() -> getLoc()

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:3164
   if (!MCE) {
-    Error(E, "expected constant '#imm' after shift specifier");
+    Error(getLoc(), "expected constant '#imm' after shift specifier");
     return MatchOperand_ParseFail;
----------------
tmatheson wrote:
> Does `parseExpression` above update the current token and hence the location?
> Does `parseExpression` above update the current token and hence the location?

Yeah thanks for pointing that out I missed that. There's actually a test for this already in `llvm/test/MC/AArch64/shift_extend_op_w_symbol.s` but whitespace was being ignored so the ^ could have been anywhere and it would pass. I've updated it to use `--match-full-lines --strict-whitespace`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106635/new/

https://reviews.llvm.org/D106635