[PATCH] D106629: [lld/mac] Implement for section$start and section$ end symbols

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/MachO/SymbolTable.cpp:219
+  OutputSection *osec = nullptr;
+  // This looks for __TEXT/__cstring etc.
+  for (SyntheticSection *ssec : syntheticSections)
----------------
oontvoo wrote:
> What about `section$start$__DATA$__<....>` ? 
That's usually a ConcatInputSection.  The "create new used" branch below works for those. (We could walk through the existing isecs and not alloc a new one if we find one with the right name, but that's more code and more chance or something to go wrong, with little benefit, so I didn't do that. An earlier version of this patch on the linked PR did that, but it's not necessary so I got rid of it.) __DATA is covered by the test below, too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106629/new/

https://reviews.llvm.org/D106629