[PATCH] D106554: [ORC] Work around AIX build compiler: Replace lambda; NFC
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 23 06:02:04 PDT 2021
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp:449
- // FIXME: Proper mangling.
+ // Use functor class to work around XL build compiler issue on AIX.
+ class RtLookupNotifyComplete {
----------------
lhames wrote:
> hubert.reinterpretcast wrote:
> > jsji wrote:
> > > Please keep this FIXME.
> > Good catch. Will do.
> Somehow I missed this. ;)
>
> If there's a bug number for that it would be good to include it, otherwise everything's good to go. :)
Thanks @lhames. We have a bug number (168299) in an internal bug tracker. Since it is not accessible to most people, I think it is better to omit it from the code comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106554/new/
https://reviews.llvm.org/D106554
More information about the llvm-commits
mailing list