[PATCH] D106652: [SelectionDAG] Support scalable splats in U(ADD|SUB)SAT combines

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 04:51:26 PDT 2021


frasercrmck added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10053
+        if (OpRHS.getOpcode() == CondRHS.getOpcode() &&
+            (OpRHS.getOpcode() == ISD::BUILD_VECTOR ||
+             OpRHS.getOpcode() == ISD::SPLAT_VECTOR) &&
----------------
I was wondering whether now's the time to add yet another function like `ISD::isBuildVectorOrSplatVector`. Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106652/new/

https://reviews.llvm.org/D106652



More information about the llvm-commits mailing list