[PATCH] D105985: Support GSYM in llvm-symbolizer.

Simon Giesecke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 03:02:05 PDT 2021


simon.giesecke added a comment.

In D105985#2899535 <https://reviews.llvm.org/D105985#2899535>, @jhenderson wrote:

> In D105985#2899504 <https://reviews.llvm.org/D105985#2899504>, @simon.giesecke wrote
>
>>> If you're adding command-line options a) they might better belong in separate later patches, and b) the documentation should be updated to reference them.
>>
>> a) Hm, ok, this will just leave us without without the option to disable GSYM usage after the first patch.
>
> Yes, this is true. I don't know if that's an issue or not though? What's the impact on a typical end user in that interim state? In other words, is it likely that something bad will happen?

Not really. A typical end user that didn't use `llvm-gsymutil` before won't be affected at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105985/new/

https://reviews.llvm.org/D105985



More information about the llvm-commits mailing list