[PATCH] D105985: Support GSYM in llvm-symbolizer.

[Simon Giesecke via Phabricator via llvm-commits]

simon.giesecke added a comment.

In D105985#2899453 <https://reviews.llvm.org/D105985#2899453>, @jhenderson wrote:

> In D105985#2892857 <https://reviews.llvm.org/D105985#2892857>, @simon.giesecke wrote:
>
>> @jhenderson I am struggling with even building cross-project-tests. How do I enable those? I tried setting calling cmake with either `-DLLVM_TOOL_CROSS_PROJECT_TESTS_BUILD=TRUE` or `-DLLVM_ENABLE_PROJECTS="clang;cross-platform-tests"`, but those don't seem to do the job.
>
> It's "cross-project-tests" not "cross-platform-tests" in the LLVM_ENABLE_PROJECTS listing.

Oh no, what a stupid mistake :( Thanks, that did the trick.

> If you're adding command-line options a) they might better belong in separate later patches, and b) the documentation should be updated to reference them.

a) Hm, ok, this will just leave us without without the option to disable GSYM usage after the first patch.

b) Sure, I'll add something to llvm/docs/CommandGuide/llvm-symbolizer.rst


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105985/new/

https://reviews.llvm.org/D105985