[PATCH] D105201: [hwasan] Detect use after scope within function.

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 02:15:24 PDT 2021


fmayer added a comment.

In D105201#2898812 <https://reviews.llvm.org/D105201#2898812>, @vitalybuka wrote:

> maybe this lazy Tree construction?

This change doesn't preserve the property that Evgenii mentioned in the comment thread about this. In Aarch64StackTagging this is done in the way it was in this change before to avoid running the analysis on the whole module if not all of the functions actually need to be instrumented. In general I think it would be nice to have the AArch64StackTagging and this implementation as close as possible, that makes it easier to reason about and I am planning to refactor this a bit to factor out the common pieces down the line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105201/new/

https://reviews.llvm.org/D105201



More information about the llvm-commits mailing list