[PATCH] D104646: [AIX][XCOFF] 64-bit relocation reading support

Fri Jul 23 01:57:30 PDT 2021

jhenderson added a comment.

Apologies, this patch somehow dropped off my radar. I've still got one outstanding comment (move the error to warning switch to a prerequisite patch). Beyond that, this should probably get another pair of eyes on it, ideally from someone with XCOFF experience. I don't feel comfortable approving it myself.

================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:136
       continue;
-    auto Relocations = unwrapOrError(Obj.getFileName(), Obj.relocations(Sec));
     if (Relocations.empty())
----------------
jhenderson wrote:
> These changes to use warnings are good, but should be their own separate patch, along with appropriate testing in tools/llvm-readobj.
It looks like this comment has been ignored? Or does this patch need rebasing on a different patch that addresses this point?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104646/new/

https://reviews.llvm.org/D104646