[PATCH] D106593: [WIP][SimplifyCFG] Replace FoldTwoEntryPHINode i1 hack with a different hack.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 00:46:36 PDT 2021


lebedev.ri added a subscriber: wmi.
lebedev.ri added a comment.

In D106593#2898508 <https://reviews.llvm.org/D106593#2898508>, @efriedma wrote:

> I guess, then, the question is what order we want to do things in.  Do we land this essentially as-is, then try to come up with a more reliable way to handle the cases that fall out?  Or do we put this on hold until we have improvements to cost estimation and/or CFG unflattening?

If this goes in as-is right now, @wmi will re-raise https://bugs.llvm.org/show_bug.cgi?id=51149
If that's fine, then let's do it, else i guess we need to try to do some legwork first.
Let me see if i can add some branch weights checks to these transforms first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106593/new/

https://reviews.llvm.org/D106593



More information about the llvm-commits mailing list