[PATCH] D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources

[Raul Tambre via Phabricator via llvm-commits]

tambre added a comment.

In D106305#2896719 <https://reviews.llvm.org/D106305#2896719>, @steven_wu wrote:

> No, this doesn't work:
>
>   CMake Error at /Users/steven/dev/monorepo/llvm-project/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:420 (add_custom_target):
>     add_custom_target cannot create target "lse_builtin_symlinks" because
>     another target with the same name already exists.  The existing target is a
>     custom target created in source directory
>     "/Users/steven/dev/monorepo/llvm-project/compiler-rt/lib/builtins".  See
>     documentation for policy CMP0002 for more details.
>   Call Stack (most recent call first):
>     /Users/steven/dev/monorepo/llvm-project/compiler-rt/lib/builtins/CMakeLists.txt:674 (darwin_add_builtin_libraries)
>   
>   
>   -- For ios_arm64e builtins preferring aarch64/fp_mode.c to fp_mode.c
>   CMake Error at /Users/steven/dev/monorepo/llvm-project/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:420 (add_custom_target):
>     add_custom_target cannot create target "lse_builtin_symlinks" because
>     another target with the same name already exists.  The existing target is a
>     custom target created in source directory
>     "/Users/steven/dev/monorepo/llvm-project/compiler-rt/lib/builtins".  See
>     documentation for policy CMP0002 for more details.
>   Call Stack (most recent call first):
>     /Users/steven/dev/monorepo/llvm-project/compiler-rt/lib/builtins/CMakeLists.txt:674 (darwin_add_builtin_libraries)
>
> That is exactly the error I got when I tried custom_target in a slightly different approach. `lse_builtin_symlinks` target is created twice by arm64 and arm64e builtin.

Thanks for testing. I think it should be fixed now, please try again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106305/new/

https://reviews.llvm.org/D106305