[PATCH] D106591: [MergeICmps] Relax sinking check

Fri Jul 23 00:15:52 PDT 2021

courbet accepted this revision.
courbet added a comment.
This revision is now accepted and ready to land.

In D106591#2899221 <https://reviews.llvm.org/D106591#2899221>, @nikic wrote:

> In D106591#2899194 <https://reviews.llvm.org/D106591#2899194>, @courbet wrote:
>
>> I'm not sure about the `nounwind`: If the function does raise a exception, we can't know that it's fine to read past the first pair of elements.
>
> The transform here is the other way around though: The loads are sunk below the other instructions. So we will do less loads if an unwind occurs, not more. As we checked that the loads are simple, that should be legal.

Ah, yes, right. Great !

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106591/new/

https://reviews.llvm.org/D106591