[PATCH] D106554: [ORC] Work around AIX build compiler: Replace lambda; NFC
Lang Hames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 22 23:38:13 PDT 2021
lhames accepted this revision.
lhames added inline comments.
================
Comment at: llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp:450-461
+ class RtLookupNotifyComplete {
+ public:
+ RtLookupNotifyComplete(SendSymbolAddressFn &&SendResult)
+ : SendResult(std::move(SendResult)) {}
+ void operator()(Expected<SymbolMap> Result) {
+ if (Result) {
+ assert(Result->size() == 1 && "Unexpected result map count");
----------------
Is there a bug filed against the AIX compiler that we could cite here?
In any case, please add a comment explaining that this was broken out due to an AIX compiler bug, and should be turned back into a lambda once the bug is fixed.
Otherwise LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106554/new/
https://reviews.llvm.org/D106554
More information about the llvm-commits
mailing list