[PATCH] D106575: [SelectionDAG] Support scalable-vector splats in yet more cases

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 22 23:15:54 PDT 2021


frasercrmck added a comment.

In D106575#2897784 <https://reviews.llvm.org/D106575#2897784>, @craig.topper wrote:

> I think the test_urem_vec looks correct. Whether it is better depends on the cost of a multiply accumulate versus shift and or which is going to be microarchitecture dependent. So I think it is fine.

Indeed. I've since added some tests to better show the combine's range. We can see it's a more obvious win on odd divisors. On even divisors it generates a `ROTR` which we expand into separate shifts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106575/new/

https://reviews.llvm.org/D106575



More information about the llvm-commits mailing list