[PATCH] D105634: [OpenMP] Use AAHeapToStack/AAHeapToShared analysis in SPMDization

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 22 18:15:29 PDT 2021


jdoerfert added a comment.

In D105634#2898821 <https://reviews.llvm.org/D105634#2898821>, @GMNGeoffrey wrote:

> Looks like you've got some missing override markers:
>
>   llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2588:8: error: 'isAssumedHeapToShared' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
>     bool isAssumedHeapToShared(CallBase &CB) const {
>          ^
>   llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2520:16: note: overridden virtual function is here
>     virtual bool isAssumedHeapToShared(CallBase &CB) const = 0;
>                  ^
>   llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2592:8: error: 'isAssumedHeapToSharedRemovedFree' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
>     bool isAssumedHeapToSharedRemovedFree(CallBase &CB) const {
>          ^
>   llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2524:16: note: overridden virtual function is here
>     virtual bool isAssumedHeapToSharedRemovedFree(CallBase &CB) const = 0;
>                  ^
>   2 errors generated.

I'll fix it real quick


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105634/new/

https://reviews.llvm.org/D105634



More information about the llvm-commits mailing list