[PATCH] D106606: [Bazel] Change external_zlib attribute to string

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb4f8a000f6c9: [Bazel] Change external_zlib attribute to string (authored by mmcloughlin, committed by GMNGeoffrey).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106606/new/

https://reviews.llvm.org/D106606

Files:
  utils/bazel/zlib.bzl


Index: utils/bazel/zlib.bzl
===================================================================
--- utils/bazel/zlib.bzl
+++ utils/bazel/zlib.bzl
@@ -24,7 +24,7 @@
         "BUILD",
         repository_ctx.attr._external_build_template,
         substitutions = {
-            "@external_zlib_repo//:zlib_rule": str(repository_ctx.attr.external_zlib),
+            "@external_zlib_repo//:zlib_rule": repository_ctx.attr.external_zlib,
         },
         executable = False,
     )
@@ -36,7 +36,7 @@
             default = Label("//deps_impl:zlib_external.BUILD"),
             allow_single_file = True,
         ),
-        "external_zlib": attr.label(
+        "external_zlib": attr.string(
             doc = "The dependency that should be used for the external zlib library.",
             mandatory = True,
         ),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106606.361015.patch
Type: text/x-patch
Size: 825 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210722/d3d05c08/attachment.bin>