[PATCH] D106606: [Bazel] Change external_zlib attribute to string

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added a comment.

In D106606#2898356 <https://reviews.llvm.org/D106606#2898356>, @mmcloughlin wrote:

> @GMNGeoffrey The pre-merge checks failed:
>
> https://buildkite.com/llvm-project/premerge-checks/builds/49068#1c2315ad-dc7b-41a5-bfda-57316dece5cd
>
> This seems unrelated to this diff. Is there something I should do to fix it?



  WARNING There were changes that could not be mapped to a project. Checking everything
  INFO    modified projects: ['clang', 'clang-tools-extra', 'compiler-rt', 'debuginfo-tests', 'flang', 'libc', 'libclc', 'libcxx', 'libcxxabi', 'libunwind', 'lld', 'lldb', 'mlir', 'openmp', 'parallel-libs', 'polly', 'pstl', 'llvm']
  Traceback (most recent call last):
    File "/var/lib/buildkite-agent/builds/llvm-premerge-checks/scripts/pipeline_premerge.py", line 56, in <module>
      affected_projects = cp.get_affected_projects(modified_projects)
    File "/var/lib/buildkite-agent/builds/llvm-premerge-checks/scripts/choose_projects.py", line 163, in get_affected_projects
      logging.info(f'added {affected_projects - changed_projects} projects as they are affected')
  TypeError: unsupported operand type(s) for -: 'set' and 'list'

So it looks to me like the logic fails in the case where no projects are affected and it somehow ends up passing in a list instead of a set for `changed_projects`. I traced the call hierarchy a bit and it looks like it gets set to a list here: https://github.com/google/llvm-premerge-checks/blob/75ca275b109e53cc268c8ada60970e780a320fcd/scripts/pipeline_premerge.py#L53

I'll file an issue/send a fix, but I think you should be fine to merge this. No premerge checks check anything about Bazel (yet) and merging this won't make the situation worse.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106606/new/

https://reviews.llvm.org/D106606