[PATCH] D106196: [Bazel] Condition Exegesis target-specific sources

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey abandoned this revision.
GMNGeoffrey added inline comments.


================
Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:2356-2359
+        ":any_x86": glob([
+            "tools/llvm-exegesis/lib/X86/*.cpp",
+            "tools/llvm-exegesis/lib/X86/*.h",
+        ]),
----------------
chandlerc wrote:
> I'm confused why we need to condition on whether the *host* is x86?
> 
> This may be obvious from the error you're fixing, but I think it would need some kind of comment here. We don't condition the x86 assembler or disassembler on the host architecture...
Ah you're totally right. This select was present in our internal config and I thought it was there for good reason, but apparently not. I've removed it there. Thanks for catching this :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106196/new/

https://reviews.llvm.org/D106196