[PATCH] D105811: [flang][driver] Delete `f18` (i.e. the old Flang driver)

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: flang/docs/Overview.md:36
 
-**Command:** `f18 -E src.f90` dumps the cooked character stream
+**Command:** `flang-new -fc1 -E src.f90` dumps the cooked character stream
 
----------------
Shouldn't the docs refer to `flang` instead of `flang-new`? AFAIU `flang` will eventually be replaced by a proper executable that does not call gfortran anymore and `flang-new` go away.


================
Comment at: flang/tools/f18/flang:185
       # The options claimed by Flang. This list needs to be compatible with
       # what's supported by Flang's compiler driver (i.e. `flang-new` and f18).
       [[ $opt == "-cpp" ]] ||
----------------



================
Comment at: flang/tools/f18/flang:239
 
   local -r ext_fc="${F18_FC:-gfortran}"
   local -r wd=$(cd "$(dirname "$0")/.." && pwd)
----------------
Is `F18_FC` still defined?


================
Comment at: flang/tools/f18/flang:317
   # flag that the driver will see (otherwise it assumes compiler/toolchain
   # driver mode).`f18` will just ignore this flag when uparsing, so it's fine
   # to add it here unconditionally.
----------------



================
Comment at: llvm/CMakeLists.txt:85
+  if (NOT "clang" IN_LIST LLVM_ENABLE_PROJECTS)
     message(FATAL_ERROR "Clang is not enabled, but it's required by the new Flang driver")
   endif()
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105811/new/

https://reviews.llvm.org/D105811