[compiler-rt] a806f93 - [dfsan] Make warn_unimplemented off by default

[Jianzhou Zhao via llvm-commits]

Author: Jianzhou Zhao
Date: 2021-07-22T21:45:41Z
New Revision: a806f933a2bf7db444c5687d8d4e07910150ed9c

URL: https://github.com/llvm/llvm-project/commit/a806f933a2bf7db444c5687d8d4e07910150ed9c
DIFF: https://github.com/llvm/llvm-project/commit/a806f933a2bf7db444c5687d8d4e07910150ed9c.diff

LOG: [dfsan] Make warn_unimplemented off by default

Because almost all internal use cases need to turn warn_unimplemented off.

Added: 
    

Modified: 
    compiler-rt/lib/dfsan/dfsan_flags.inc
    compiler-rt/test/dfsan/flags.c

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/dfsan/dfsan_flags.inc b/compiler-rt/lib/dfsan/dfsan_flags.inc
index 6363e8c5adb17..67fda0eee490d 100644
--- a/compiler-rt/lib/dfsan/dfsan_flags.inc
+++ b/compiler-rt/lib/dfsan/dfsan_flags.inc
@@ -16,7 +16,7 @@
 // DFSAN_FLAG(Type, Name, DefaultValue, Description)
 // See COMMON_FLAG in sanitizer_flags.inc for more details.
 
-DFSAN_FLAG(bool, warn_unimplemented, true,
+DFSAN_FLAG(bool, warn_unimplemented, false,
            "Whether to warn on unimplemented functions.")
 DFSAN_FLAG(bool, warn_nonzero_labels, false,
            "Whether to warn on unimplemented functions.")

diff  --git a/compiler-rt/test/dfsan/flags.c b/compiler-rt/test/dfsan/flags.c
index b99feab5805c4..1a21209e7019c 100644
--- a/compiler-rt/test/dfsan/flags.c
+++ b/compiler-rt/test/dfsan/flags.c
@@ -1,4 +1,4 @@
-// RUN: %clang_dfsan %s -fsanitize-ignorelist=%S/Inputs/flags_abilist.txt -mllvm -dfsan-debug-nonzero-labels -o %t && %run %t 2>&1 | FileCheck %s
+// RUN: %clang_dfsan %s -fsanitize-ignorelist=%S/Inputs/flags_abilist.txt -mllvm -dfsan-debug-nonzero-labels -o %t && DFSAN_OPTIONS=warn_unimplemented=1 %run %t 2>&1 | FileCheck %s
 // RUN: %clang_dfsan %s -fsanitize-ignorelist=%S/Inputs/flags_abilist.txt -mllvm -dfsan-debug-nonzero-labels -o %t && DFSAN_OPTIONS=warn_unimplemented=0 %run %t 2>&1 | count 0
 // RUN: %clang_dfsan %s -fsanitize-ignorelist=%S/Inputs/flags_abilist.txt -mllvm -dfsan-debug-nonzero-labels -o %t && DFSAN_OPTIONS=warn_nonzero_labels=1 %run %t 2>&1 | FileCheck --check-prefix=CHECK-NONZERO %s
 //