[PATCH] D106596: [lld-macho][nfc] Add test for resolution of LTO symbols

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 22 14:23:28 PDT 2021


int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added subscribers: ormris, steven_wu, hiraditya, inglorion.
Herald added a reviewer: gkm.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We lacked a test for LTO symbol precedence. We assumed that
they followed the same rules as their regular symbol counterparts, but
never had a test to verify that we were matching ld64's behavior. It
turns out that we were largely correct, though we deviate from ld64 when
there are bitcode and non-bitcode symbols of the same name. The test
added in this diff both verifies our behavior and documents the
differences.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106596

Files:
  lld/test/MachO/lto-symbol-resolution.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106596.360974.patch
Type: text/x-patch
Size: 4948 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210722/5e65c64c/attachment.bin>


More information about the llvm-commits mailing list