[PATCH] D106211: [lld-macho] Reorganize + extend ICF test
Greg McGary via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 22 13:42:26 PDT 2021
gkm accepted this revision.
gkm added a comment.
This revision is now accepted and ready to land.
Nice! Yes, the terse non-descriptive names were getting out of hand.
================
Comment at: lld/test/MachO/icf.s:69-73
+# CHECK: callq 0x[[#%x,MR2:]] <_mr2>
+# CHECK: callq 0x[[#%x,MR2:]] <_mr2>
+## FIXME: Mutually-recursive functions with identical bodies (see below)
+# COM: callq 0x[[#%x,XR]] <_xr2>
+# COM: callq 0x[[#%x,XR]] <_xr2>
----------------
These could benefit from descriptive names too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106211/new/
https://reviews.llvm.org/D106211
More information about the llvm-commits
mailing list