[PATCH] D106585: Fix clang debug info irgen of i128 enums
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 22 13:27:54 PDT 2021
dblaikie added inline comments.
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3117
+ llvm::APSInt Value = Enum->getInitVal();
+ Value.setIsSigned(IsSigned);
+ Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value));
----------------
Is the value already signed appropriately?
Removing this line of code (and the `bool IsSigned` variable, so it doesn't break `-Werror=unused-variable`) doesn't cause any tests to fail, that I can see.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106585/new/
https://reviews.llvm.org/D106585
More information about the llvm-commits
mailing list