[Diffusion] rG5419b671375c: [SimplifyCFG] Update FoldTwoEntryPHINode to handle and/or of select and binop…

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In rG5419b671375c46299ff1da6c929859040e7beaf5#1014705 <https://reviews.llvm.org/rG5419b671375c46299ff1da6c929859040e7beaf5#1014705>, @lebedev.ri wrote:

> In rG5419b671375c46299ff1da6c929859040e7beaf5#1014700 <https://reviews.llvm.org/rG5419b671375c46299ff1da6c929859040e7beaf5#1014700>, @nikic wrote:
>
>> @lebedev.ri We canonicalize to the correct form in InstCombine. At which point does SimplifyCFG produce the non-canonical form?
>
> At any point where it produces a boolean select where one of it's operands happens to be a constant,
> one that doesn't happen to match the expected constant for that operand.

I guess the question would be more precisely: Where does it produce such a select where it previously would have produced a bitwise and/or?


BRANCHES
  llvm_jit_comment, main, ml-spread-test

Users:
  aqjune (Author)

https://reviews.llvm.org/rG5419b671375c