[PATCH] D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type

Nick Fitzgerald via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 22 12:52:09 PDT 2021


fitzgen updated this revision to Diff 360936.
fitzgen added a comment.

Updated to only hash/compare `WasmLimits`'s `Maximum` when `Flags & WASM_LIMITS_FLAGS_HAS_MAX`. This should fix the use of uninitialized data that led to reverting the original commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105519/new/

https://reviews.llvm.org/D105519

Files:
  lld/test/wasm/duplicate-function-imports.s
  lld/test/wasm/duplicate-global-imports.s
  lld/test/wasm/duplicate-table-imports.s
  lld/wasm/SyntheticSections.cpp
  lld/wasm/SyntheticSections.h
  lld/wasm/Writer.cpp
  llvm/include/llvm/BinaryFormat/Wasm.h
  llvm/include/llvm/BinaryFormat/WasmTraits.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105519.360936.patch
Type: text/x-patch
Size: 14712 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210722/325de516/attachment.bin>


More information about the llvm-commits mailing list