[Diffusion] rG5419b671375c: [SimplifyCFG] Update FoldTwoEntryPHINode to handle and/or of select and binop…

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 22 12:30:12 PDT 2021


lebedev.ri added subscribers: llvm-commits, spatel, nikic, wmi, lebedev.ri.
lebedev.ri added a comment.

@aqjune i'm concerned about logical and/or.
I think they should either be their own binary operators, or we need to somehow make a much better job
at not forgetting that they can trivially degrade into their inverted form (`!c1 ? true : c2` -> `c1 ? c2 : true`; `!c1 ? c2 : false` -> `c1 ? false : c2`).
I've just patched one such bug (rG7ef6f019090f3979fa345105b9ac95ac589c6cf9 <https://reviews.llvm.org/rG7ef6f019090f3979fa345105b9ac95ac589c6cf9>), and that one originally manifested as a huge perf regression in https://bugs.llvm.org/show_bug.cgi?id=51149


BRANCHES
  llvm_jit_comment, main, ml-spread-test

Users:
  aqjune (Author)

https://reviews.llvm.org/rG5419b671375c



More information about the llvm-commits mailing list