[PATCH] D106457: [Matrix] Fix miscompile for NT matmul if the transpose has other use

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 22 11:33:54 PDT 2021


MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1144
+    auto inserted = Inst2ColumnMatrix.insert(std::make_pair(Inst, Matrix));
+    assert(inserted.second && "multiple matrix lowering mapping");
 
----------------
Hi, there was a -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off build

Fixed by 3b181568db8efc30b79466bba4aa334f86a49877


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106457/new/

https://reviews.llvm.org/D106457



More information about the llvm-commits mailing list