[PATCH] D106445: [amdgpu] Add 64-bit PC support when expanding unconditional branches.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:2307
   RS->setRegUsed(Scav);
 
+  // Now, the distance could be defined.
----------------
This is supposed to return the number of bytes added, not necessarily the size of the block. At least should assert the block is empty, which I think is always the case 


================
Comment at: llvm/test/CodeGen/AMDGPU/branch-relaxation-debug-info.mir:12
+# GCN-NEXT: [[POST_GETPC:.Lpost_getpc[0-9]+]]:{{$}}
+# GCN-NEXT:    s_add_u32 s[[PC_LO]], s[[PC_LO]], (BB0_4-[[POST_GETPC]])&4294967295
+# GCN-NEXT:    s_addc_u32 s[[PC_HI]], s[[PC_HI]], (BB0_4-[[POST_GETPC]])>>32
----------------
It would be better if this mask was printed as hex, but I guess there’s no direct control over this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106445/new/

https://reviews.llvm.org/D106445