[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

[Chris Lattner via Phabricator via llvm-commits]

lattner added a comment.

> @lattner, thanks for the help. In this case, the real question is whether there's any use case for !srcloc that involves writing it out into a bitcode or IR file and then having a separate instance of clang load it back in again.



> I think that no such case can possibly give a useful mapping back to the original source, because IR doesn't serialise the SourceManager that knows how to turn source locations back into a useful error message.

Right, the only use case is with the entire compiler integrated together, for exactly the reason you point out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105491/new/

https://reviews.llvm.org/D105491