[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:40
+
+static const StringRef AllStdExts = "mafdqlcbjtpvn";
+
----------------
Make this `static constexpr StringLiteral AllStdExts = "mafdqlcbjtpvn";`


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:396
+    bool Add = ExtName[0] == '+';
+    ExtName = ExtName.drop_front(1); // Drop '+'
+    Experimental = stripExperimentalPrefix(ExtName);
----------------
This comment should be "Drop '+' or '-'" I think?


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:544
+      // Currently LLVM supports only "mafdcbv".
+      {
+        return createStringError(
----------------
This is an unusual placement of curly braces. Put the comment inside?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105168/new/

https://reviews.llvm.org/D105168