[PATCH] D106556: [OpenMPOpt] Move dedup runtime calls after init for target regions
Joseph Huber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 22 08:28:37 PDT 2021
jhuber6 added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1582
+ };
+ emitRemark<OptimizationRemark>(&F, "OpenMPRuntimeCodeMotion", Remark);
+
----------------
jdoerfert wrote:
> @jhuber6 suggested to not emit a remark here and removed it earlier.
Yeah, I decided that it wasn't really important for the user to know that the call was moved anywhere and just cluttered up the existing remarks. Mostly because the user has no clue where the beginning of the OpenMP region truly exists in their code and it's not really an optimization per-se. If you want to add it in you'd also need to give it an `OMPxxx` number and write some documentation for it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106556/new/
https://reviews.llvm.org/D106556
More information about the llvm-commits
mailing list