[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 22 08:15:08 PDT 2021


craig.topper added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:504
                                                              VScale, VScale));
+  } else if (getContext().getTargetInfo().hasFeature("sve")) {
+    CurFn->addFnAttr(
----------------
Is there any way we can check that the target is ARM before checking an "sve" on a target independent interface? If any other target uses the name "sve" this will trigger.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106277/new/

https://reviews.llvm.org/D106277



More information about the llvm-commits mailing list